Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update datatest to work on 1.40 #20

Merged
merged 4 commits into from
Oct 23, 2019
Merged

Conversation

estebank
Copy link
Contributor

Add new required field to TestDesc.

Add new required field to `TestDesc`.
@estebank estebank requested a review from idubrov October 22, 2019 23:41
@idubrov
Copy link
Contributor

idubrov commented Oct 22, 2019

Yeah, I have another PR open for it #19. I'm kind of holding it off since not sure if I want to merge it before tests pass on stable. But stable is not yet released, so maybe it's okay.

@estebank
Copy link
Contributor Author

This will require latest version to support <=1.38 and a new version for newer versions. I can put this behind a feature flag if you want.

CC #18

@estebank estebank changed the title Update datatest to work on 1.39 Update datatest to work on 1.40 Oct 22, 2019
@estebank
Copy link
Contributor Author

estebank commented Oct 23, 2019

This won't be needed until 1.40 (1.39 is fine), but I feel that the feature flag approach should be a reasonable imposition. What do you think? We could even peek the compiler version to enable the right feature so that it is seamless. Keep forgetting that this is not possible.

@idubrov idubrov merged commit 3ca7b15 into commure:master Oct 23, 2019
@cormacrelf
Copy link
Contributor

2 notes:

@idubrov
Copy link
Contributor

idubrov commented Nov 3, 2019

Uh-oh. I'll take a look.

Yeah, I copied your changes from #19 to #21, but haven't merged them / finished (I tried used your branch initially, but messed up the merge).

@cormacrelf
Copy link
Contributor

continue over at #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants